Repository navigation
fix(rootly): map the in_triage incident status to TODO - #9404
Open
ShivamSharma43 wants to merge 1 commit into
Open
ShivamSharma43 wants to merge 1 commit into
ShivamSharma43 wants to merge 1 commit into
Conversation
mapStatus matched "triage", but Rootly's incident status is
"in_triage" ("triage" is not in its API's status enum). In-triage
incidents fell through to the default branch, became IN_PROGRESS and
logged an unknown status warning.
Match "in_triage", and use the real value in the unit test and the
e2e fixtures.
Generated-by: Claude Code (Claude Opus 5.5)
Signed-off-by: Shivam Sharma <192242476+ShivamSharma43@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Rootly
convertIncidentssubtask maps the statustriagetoTODO, but Rootly never returnstriage. Its API calls that statusin_triage.The incident
statusenum in Rootly's OpenAPI spec (https://rootly-heroku.s3.amazonaws.com/swagger/v1/swagger.json) isin_triage, started, detected, acknowledged, mitigated, resolved, closed, cancelled, scheduled, in_progress, completed. There is notriage. SomapStatushas no case for real in-triage incidents. They fall through to the default branch:issues.statusbecomesIN_PROGRESSinstead ofTODO, and the converter logsunknown rootly incident status: in_triageonce for every such incident.Changes:
tasks/incidents_converter.go:mapStatusmatchesin_triageinstead oftriage.tasks/incidents_converter_test.go: theTestMapStatuscase usesin_triage. With the old code it fails (expected: "TODO",actual: "IN_PROGRESS").e2e/raw_tables/_raw_rootly_incidents.csvand the_tool_rootly_incidents.csv/issues.csvsnapshots: incidentinc_01now has the real status valuein_triageinstead oftriage. Its domain status staysTODO. Only that one value changes.No migration: rows are rewritten on the next conversion.
Does this close any open issues?
No issue is open for this. The bug is described above.
Screenshots
N/A
Other Information
go test ./plugins/rootly/tasks/: pass. The e2e test needsE2E_DB_URL, which I didn't run locally. The fixture change only swaps the status string in the raw row and the two snapshots that copy it.go vet ./plugins/rootly/...andgofmt: clean.detected,acknowledged,scheduledandin_progress, which still fall back toIN_PROGRESSwith a warning. I left them out to keep this PR small. I can map them in a follow-up if you want.pr-type/bug-fix.Generated-by:trailer, following the ASF generative tooling guidance.🤖 Generated with Claude Code